This repository was archived by the owner on Mar 17, 2024. It is now read-only.
Added Support for custom passworded certificates.#789
Closed
ndragon798 wants to merge 2 commits intoquasar:masterfrom
ndragon798:master
Closed
Added Support for custom passworded certificates.#789ndragon798 wants to merge 2 commits intoquasar:masterfrom ndragon798:master
ndragon798 wants to merge 2 commits intoquasar:masterfrom
ndragon798:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the support for custom passworded certificates to do this I had to implement sha1 into both the client and server and change most of the calls for the certs to also pull the password in settings.
I see one improvement from this that would be not storing the cert pass in plain text but that would require adding a password field to the entire program and then using that password to hash the settings.xml