feat(ui/QTable) QTable slot row-expand #8350 #13014
Conversation
Hi guys, here is PR for Czech language :)
Razi91
changed the title
Razi91
force-pushed
the
QTable-slot-expanded
branch
3 times, most recently
from
6851f10 to
a46a5b0
Compare
|
Updated and fixed for virtualscroll. However, I'm not sure about performance, especially with virtualscroll. It shouldn't provide any breaking change, the slot is completely opt-in. |
| { | ||
| name: 'before', | ||
| format: () => '' | ||
| }, |
There was a problem hiding this comment.
In QTableProps['columns'] type, name, label and field are required
| const columns = [ | ||
| { | ||
| name: 'before', | ||
| format: () => '' |
There was a problem hiding this comment.
In QTableProps['columns'] type, name, label and field are required
| const columns = [ | ||
| { | ||
| name: 'before', | ||
| format: () => '' |
There was a problem hiding this comment.
In QTableProps['columns'] type, name, label and field are required
ui/src/components/table/QTable.json
Outdated
| }, | ||
|
|
||
| "row-expand": { | ||
| "desc": "Slot to define how a body row looks like; Suggestion: QTr + Td with `colspan=\"100%\"`", |
There was a problem hiding this comment.
Slot to define how the expanded part of a row looks like; Suggestion: QTr + Td with colspan=\"100%\"
Razi91
force-pushed
the
QTable-slot-expanded
branch
from
3537f04 to
352b12f
Compare
|
Hello everyone, |
|
Still waiting, fixed the comments in feedback, now still waiting.... |
|
I'm not part of the Quasar team. I just made few comments in order to help the PR getting approved. |
|
+1, expand-row slot would be a great addition. |
|
What's needed to get this merged besides resolving the branch conflict? |
9 participants
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
devbranch (orv[X]branch)fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Simplifies using
expandon QTable by defining just the additional row, instead of rewriting the wholebodyslot, described in #8350 by adding slotrow-expandwithtrinside. Thistrwill be added always, in this place user should decide if it should by hidden byv-showorv-if.