Adding SSL Support (#1)#10
Merged
sinchb merged 1 commit intoquatanium:masterfrom Jul 4, 2017
Merged
Conversation
Contributor
texnofobix
commented
Sep 23, 2016
texnofobix
commented
- Adding SSL Support
* Adding SSL Support Enabling SSL Support on Foscams. * Fixing SSL assumptions
sinchb
reviewed
Sep 23, 2016
| import ssl | ||
| ssl_enabled=True | ||
| except ImportError: | ||
| ssl_enabled=False |
There was a problem hiding this comment.
Hi, I see this is an old pull request. I'm interested in seeing ssl being added to the lib. what would be a better way to handle the import error?
maybe if this is the only error this could be merged and a we could have a fix commit later?
or is it ok to submit a new pull request if the author of this pull request isn't going to update this one?
thanks
Contributor
Author
|
I'll admit, I'm not great with Python. I'll gladly take suggestions. :) |
Contributor
|
see this : https://www.python.org/dev/peps/pep-0008/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.