Skip to content

Hum distro#1861

Merged
github-actions[bot] merged 2 commits into
quay:mainfrom
crozzy:hum-distro
May 14, 2026
Merged

Hum distro#1861
github-actions[bot] merged 2 commits into
quay:mainfrom
crozzy:hum-distro

Conversation

@crozzy
Copy link
Copy Markdown
Contributor

@crozzy crozzy commented Apr 30, 2026

Hummingbird being a Red Hat product but having a non-typical RHEL
os-release file means it needs a special-case in the RHEL distribution
detector.

Also remove redhat-release support (and oracle hack)

@crozzy
Copy link
Copy Markdown
Contributor Author

crozzy commented Apr 30, 2026 

"distributions": {
    "1": {
        "id": "1",
        "did": "hummingbird",
        "name": "Hummingbird OS",
        "version": "20251124",
        "version_code_name": "",
        "version_id": "20251124",
        "arch": "",
        "cpe": "cpe:2.3:a:redhat:hummingbird:1:*:*:*:*:*:*:*",
        "pretty_name": "Hummingbird OS 20251124"
    }
},

@crozzy crozzy marked this pull request as ready for review April 30, 2026 22:54
@crozzy crozzy requested a review from a team as a code owner April 30, 2026 22:54
@crozzy crozzy requested review from hdonnay and removed request for a team April 30, 2026 22:54
@BradLugo BradLugo self-requested a review May 1, 2026 00:26
@crozzy crozzy force-pushed the hum-distro branch 3 times, most recently from f0fcd8f to 3bcdd79 Compare May 4, 2026 15:30
BradLugo
BradLugo previously approved these changes May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@BradLugo BradLugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some optional nits

Comment thread rhel/distributionscanner_test.go Outdated
Comment thread rhel/distributionscanner.go
Comment thread rhel/distributionscanner.go Outdated
@crozzy crozzy requested a review from BradLugo May 6, 2026 15:18
@crozzy crozzy force-pushed the hum-distro branch 3 times, most recently from 1e586d1 to 5e9d465 Compare May 6, 2026 17:02
crozzy added 2 commits May 14, 2026 08:54
@crozzy
rhel: update distribution detector to find hummingbird distros
eb09911 
Hummingbird being a Red Hat product but having a non-typical RHEL
os-release file means it needs a special-case in the RHEL distribution
detector.

Signed-off-by: crozzy <joseph.crosland@gmail.com>
@crozzy
rhel: remove redhat-release file support from distribution detector
7f15458 
The redhat-release file was last used in RHEL 6 which hasn't been
supported for some time (https://access.redhat.com/articles/4665701).
This data isn't used in matching so should be safe even if there was
somehow a need to match to Red Hat VEX advisories.

Signed-off-by: crozzy <joseph.crosland@gmail.com>
hdonnay
hdonnay approved these changes May 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@hdonnay hdonnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I do like removing the funky Oracle bits 👍

@crozzy
Copy link
Copy Markdown
Contributor Author

crozzy commented May 14, 2026

/fast-forward

@github-actions github-actions Bot merged commit 7f15458 into quay:main May 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hdonnay hdonnay hdonnay approved these changes

@BradLugo BradLugo Awaiting requested review from BradLugo

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crozzy @hdonnay @BradLugo