matcher: fix send on closed channel#1872
Merged
Merged
Conversation
It was possible for the matching process to panic if the TryGo loop sneaks in an extra worker as the Sender or Collector finishes and frees up a slot mid-loop. This change adds workerWg.Add(1) and immediately decrements if TryGo doesn't go, then does the usual thing of waiting for the workerWg. Signed-off-by: crozzy <joseph.crosland@gmail.com>
hdonnay
approved these changes
May 13, 2026
Member
hdonnay
left a comment
hdonnay
left a comment
There was a problem hiding this comment.
Yeah, much better than atomic tricks.
Contributor
Author
|
/fast-forward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was possible for the matching process to panic if the TryGo loop sneaks in an extra worker as the Sender or Collector finishes and frees up a slot mid-loop. This would mean that an attempted write could happen on a closed channel.
This change adds workerWg and immediately decrements if TryGo doesn't, errrm, go, then does the usual thing of waiting for the workerWg before closing.