Skip to content

Conversation

@kurtismullins
Copy link
Contributor

This PR is my suggested procedure to update from Quay Operator v1.0.2 to v3.3.0.
It is not written in the correct format, so please do not merge it.
This Pull Requests exists for review and/or re-writing purposes.

@kurtismullins
Copy link
Contributor Author

Two notes from a quick glance over it myself:

  1. The requirement for down-time and suggesting a maintenance window and informing users should be more prominently written towards the top of the documentation.
  2. If the Quay deployment has any custom configuration they've performed by modifying the secret, or otherwise, then that configuration will have to be re-applied.

If your deployment does not specify any specific network-related configuration
values, this step may not be necessary. Please refer to the documentation to
ensure that your the configuration options in your current CR are still
accurate for Quay Operator v3.3.0.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when customers read this notes, where can they search and validate the previous CR configurations?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed "ensure that your the" to "ensure that the". As for the CR, I'll leave this for @kurtismullins and keep it open for now.

certificate may have been created by this process.

If multiple replicas are needed to scale your Quay registry, it is now safe
to change the replica count to your desired quantity.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls review is it necessary to let customers know how to update Quay CR file to scale out quay,
for example: suppose the CR name is "demo-quayecosystem", then in order to scale out quay, customers can run "oc edit quayecosystem demo-quayecosystem", change "replicas: 1" to "replicas: 2", or other desired number.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Fixed content in proc_deploy-quay-openshift-operator.adoc.

@chrisnegus
Copy link
Contributor

@kurtismullins I copied this content into a separate section of the "Deploy Quay on OpenShift with Quay Operator" guide. I'm adding the comments from here into that doc.

@chrisnegus
Copy link
Contributor

I'm going to close this PR, since the content and corrections were added to the file proc_deploy-quay-openshift-operator.adoc in PR #56.

@chrisnegus chrisnegus closed this May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants