Fix silent failures in SELinux enabled distros and when keyring is not available #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order for qubesome to work in environments where SELinux is enabled and enforced the container execution needs to opt-out from SELinux. For profiles, it is likely that this will be reverse once we ship a qubesome-specific SELinux policy. For general workloads that is less likely. Signed-off-by: Paulo Gomes <pjbgf@linux.com>
The mtls data storage is largely a convenience feature which enables things such as mime handling. This change ensures that a profile can still be started regardless of it. Signed-off-by: Paulo Gomes <pjbgf@linux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for qubesome to work in environments where SELinux is enforced the container execution needs to opt-out from SELinux. For profiles, it is likely that this will be reverse once we ship a qubesome-specific SELinux policy. For general workloads that is less likely.
This changes will also ensure that mtls data storage errors does not cause a hard failure.