Fix preprocessor guard for loading execution fee files on non-scratch…#793
Merged
Franziska-Mueller merged 1 commit intodevelopfrom Mar 12, 2026
Merged
Conversation
… restart Changed #ifndef to #if ! so that loadContractExecFeeFiles() is called when START_NETWORK_FROM_SCRATCH is 0 (node joining existing network). The #ifndef check always skipped loading because the macro is always defined, causing misalignment after epoch transition.
Franziska-Mueller
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
#ifndefto#if !so thatloadContractExecFeeFiles()is called whenSTART_NETWORK_FROM_SCRATCHis0(node joining existing network). The#ifndefcheck always skipped loading because the macro is always defined, causing misalignment after epoch transition.When a node is starting with
START_NETWORK_FROM_SCRATCH = 0the filecontract_exec_fees_rec.xxxis required.