Skip to content

Adds TransferSharesToManyV1 to QUTIL#803

Merged
Franziska-Mueller merged 7 commits into
qubic:developfrom
double-k-3033:feature/qutil
Apr 16, 2026
Merged

Adds TransferSharesToManyV1 to QUTIL#803
Franziska-Mueller merged 7 commits into
qubic:developfrom
double-k-3033:feature/qutil

Conversation

@double-k-3033
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@philippwerner philippwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Overall, it looks good to me. Just the following comments:

Why did you change the DebugInformationFormat in the platform libraries? Is there any problem with the "ProgramDatabase" setting that is fixed by changing the value to "OldStyle"? If there isn't a good reason, please undo the changes in the *.vcxproj files.

If management rights are transferred to QUTIL, it also must offer a way to transfer the rights back to other contracts. So please add a procedure TransferShareManagementRights for that purpose to QUTIL.

@double-k-3033
Copy link
Copy Markdown
Contributor Author

I'm sorry. An error occurred during the build process, so I had no choice but to change it that way. I forgot that I shouldn't push the related files when I push.

Comment thread src/contracts/QUtil.h Outdated
@double-k-3033 double-k-3033 requested a review from krypdkat March 25, 2026 14:50
Comment thread src/contracts/QUtil.h Outdated
Comment thread src/contracts/QUtil.h Outdated
@double-k-3033 double-k-3033 requested a review from krypdkat March 25, 2026 15:25
@philippwerner philippwerner changed the title Feature/qutil Adds TransferSharesToManyV1 to QUTIL Apr 13, 2026
Copy link
Copy Markdown
Contributor

@philippwerner philippwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Please address the following comments.

Comment thread src/contracts/QUtil.h Outdated
Comment thread src/contracts/QUtil.h Outdated
Comment thread src/contracts/QUtil.h Outdated
Comment thread src/contracts/QUtil.h Outdated
Comment thread src/contracts/QUtil.h Outdated
Copy link
Copy Markdown
Contributor

@philippwerner philippwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the comments. All is looking good now, except for one remaining issue.

Comment thread src/contracts/QUtil.h Outdated
@double-k-3033
Copy link
Copy Markdown
Contributor Author

@philippwerner
plz give me the feedback to solve this : #823 (comment)

@Franziska-Mueller
Copy link
Copy Markdown
Collaborator

@double-k-3033 please merge the newest version of the develop branch into your branch. we have reenabled the automatic contract verification for the QUtil file.

@double-k-3033
Copy link
Copy Markdown
Contributor Author

@double-k-3033 please merge the newest version of the develop branch into your branch. we have reenabled the automatic contract verification for the QUtil file.

what is it for?

@Franziska-Mueller
Copy link
Copy Markdown
Collaborator

@double-k-3033 please merge the newest version of the develop branch into your branch. we have reenabled the automatic contract verification for the QUtil file.

what is it for?

We have an automatic verification tool that checks changes in SC files for forbidden C++ language features (you can see it running as ContractVerify workflow). We had to disable this automatic check for the QUtil file a few weeks ago because the verification tool couldn't handle the oracle-related code in QUtil.
I patched the tool today. I wanted you to merge s.t. the verification tool with the newest version runs on your QUtil file. For example the forbidden use of a local variable that Phil flagged before would usually have been caught by the workflow already. I asked you to do this to make sure that there are no other forbidden language features that were overlooked in the manual review.

@double-k-3033
Copy link
Copy Markdown
Contributor Author

double-k-3033 commented Apr 15, 2026

@double-k-3033 please merge the newest version of the develop branch into your branch. we have reenabled the automatic contract verification for the QUtil file.

what is it for?

We have an automatic verification tool that checks changes in SC files for forbidden C++ language features (you can see it running as ContractVerify workflow). We had to disable this automatic check for the QUtil file a few weeks ago because the verification tool couldn't handle the oracle-related code in QUtil. I patched the tool today. I wanted you to merge s.t. the verification tool with the newest version runs on your QUtil file. For example the forbidden use of a local variable that Phil flagged before would usually have been caught by the workflow already. I asked you to do this to make sure that there are no other forbidden language features that were overlooked in the manual review.

Thx for your support. As you can see, All checks have passed.
And then plz support me for #823 PR 🙏🏻
I really need your help.
Thx in advance. ✨

@Franziska-Mueller Franziska-Mueller merged commit 2f1ff54 into qubic:develop Apr 16, 2026
2 checks passed
@philippwerner philippwerner linked an issue Apr 21, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add TransferSharesToManyV1() to QUTIL

4 participants