Adds TransferSharesToManyV1 to QUTIL#803
Conversation
philippwerner
left a comment
There was a problem hiding this comment.
Thanks for the contribution. Overall, it looks good to me. Just the following comments:
Why did you change the DebugInformationFormat in the platform libraries? Is there any problem with the "ProgramDatabase" setting that is fixed by changing the value to "OldStyle"? If there isn't a good reason, please undo the changes in the *.vcxproj files.
If management rights are transferred to QUTIL, it also must offer a way to transfer the rights back to other contracts. So please add a procedure TransferShareManagementRights for that purpose to QUTIL.
|
I'm sorry. An error occurred during the build process, so I had no choice but to change it that way. I forgot that I shouldn't push the related files when I push. |
c794718 to
e8f0f14
Compare
e8f0f14 to
9ce0779
Compare
51ca19e to
e20242b
Compare
philippwerner
left a comment
There was a problem hiding this comment.
Thanks for your contribution. Please address the following comments.
e700588 to
994b3c6
Compare
philippwerner
left a comment
There was a problem hiding this comment.
Thanks for addressing all the comments. All is looking good now, except for one remaining issue.
|
@philippwerner |
|
@double-k-3033 please merge the newest version of the |
what is it for? |
We have an automatic verification tool that checks changes in SC files for forbidden C++ language features (you can see it running as ContractVerify workflow). We had to disable this automatic check for the QUtil file a few weeks ago because the verification tool couldn't handle the oracle-related code in QUtil. |
Thx for your support. As you can see, All checks have passed. |
No description provided.