Merged
Conversation
Collaborator
|
please provide a description of the SC in your PR description or link to the proposal |
Contributor
Author
|
@Franziska-Mueller, done |
cyber-pc
reviewed
Apr 12, 2026
| while (locals.elementIndex != NULL_INDEX | ||
| && locals.elementIndex2 < ESCROW_MAX_DEALS_PER_USER) | ||
| { | ||
| if (state.get()._deals.get(state.get()._ownerDealIndexes.element(locals.elementIndex), locals.tempDeal)) |
Collaborator
There was a problem hiding this comment.
This potentially cause an infinite loop if this check is false ?
Contributor
Author
There was a problem hiding this comment.
In practice, this scenario shouldn’t occur, but you are right - it could potentially lead to an infinite loop. Fixed, thanks!
cyber-pc
approved these changes
Apr 13, 2026
Collaborator
cyber-pc
left a comment
cyber-pc
left a comment
There was a problem hiding this comment.
LGTM, you need to merge develop into this to resolve the conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal