-
Notifications
You must be signed in to change notification settings - Fork 6
Openapi v3 #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openapi v3 #44
Conversation
# Conflicts: # protobuff/qubic.proto
| option (google.api.http) = { | ||
| post: "/querySmartContract" | ||
| body: "*" | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that is not part of the original scope of the PR, but can we document the body?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added documentation
| option (google.api.http) = { | ||
| post: "/broadcast-transaction" | ||
| body: "*" | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that is not part of the original scope of the PR, but can we document the body?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added documentation.
| type: integer | ||
| description: current network tick | ||
| format: uint32 | ||
| duration: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a description for the duration and indicate in which unit is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for a response from core about the value and it's unit of measurement.
protobuff/qubic.proto
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we describe this
int64 balance = 2;
uint32 valid_for_tick = 3;
uint32 latest_incoming_transfer_tick = 4;
uint32 latest_outgoing_transfer_tick = 5;
int64 incoming_amount = 6;
int64 outgoing_amount = 7;
uint32 number_of_incoming_transfers = 8;
uint32 number_of_outgoing_transfers = 9; ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added documentation.
No description provided.