Allow passing keyword arguments to backbone models (#230) #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qubvel
reviewed
Feb 26, 2020
segmentation_models/models/_utils.py
Outdated
| return | ||
|
|
||
|
|
||
| def get_submodules_args(kwargs): |
Owner
There was a problem hiding this comment.
Lets call it filter_kwargs or smth like that, so it would be more clear?
It is kind of messy to have get_submodules_from_kwargs and get_submodules_args
Contributor
Author
There was a problem hiding this comment.
Is renaming get_submodules_args to filter_keras_submodules enough?
lukfischer
pushed a commit
to SCCH-KVS/segmentation_models
that referenced
this pull request
May 11, 2020
Allow passing keyword arguments to backbone models (qubvel#230) (qubvel#291)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make kwargs supported (#230)
Instead of writing custom
get_submodules_from_kwargsfunction, I decided to filter arguments passed to this function but the basic idea is same.