fix: fix cluster test that tests copying remote data to local machine#270
Merged
leahaeusel merged 1 commit intoqueens-py:mainfrom Jan 23, 2026
Merged
Conversation
Contributor
danielwolff1
left a comment
danielwolff1
left a comment
There was a problem hiding this comment.
Ups, I'm very sorry about that 😅
When implementing this test I was comparing my adaption to the existing check but I oversaw that the existing check was comparing against the raw data loaded from the .pickle file and not against data loaded from the .vtu files on the remote machine. But yeah, checks out that if we draw 2 samples with the MonteCarlo iterator that two independent folders will be created in the experiment directory and we have to check both for their output...
Thanks for spotting (and fixing! 🙏) my mistake here! 😬
maxdinkel
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Context:
What and Why?
This PR fixes the cluster test responsible for testing the new
copy_files_from_experiment_dir()method. This method copies files from the remote experiment directory to the local machine.The way the test has been implemented so far hasn't yet taken into account the file structure of the experiment directory. Therefore, our cluster tests have been failing.
I have tested the new implementation via a pipeline run on GitLab.
Related Issues and Pull Requests
Interested Parties
@danielwolff1