fix(converter): emoji 패키지 미설치 시 converter 실행을 중단합니다#645
Merged
Conversation
- context.py: EMOJI_AVAILABLE 플래그를 제거하고, emoji import 실패 시 SystemExit을 발생시킵니다. - core.py: EMOJI_AVAILABLE 분기를 제거하고, emoji.emojize()를 직접 호출합니다. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
emoji패키지가 설치되지 않은 경우, converter가 조용히 fallback 경로를 타며 shortname(:check_mark:)을 그대로 출력하는 문제를 수정합니다.EMOJI_AVAILABLE플래그를 제거하고, import 실패 시SystemExit으로 즉시 중단합니다.core.py의 불필요한EMOJI_AVAILABLE분기를 제거하여 코드를 단순화합니다.Related
Test plan
🤖 Generated with Claude Code