fix(reverse-sync): frontmatter 제외 비교 및 마크다운 링크 정규화로 verify 실패 수정#650
Merged
fix(reverse-sync): frontmatter 제외 비교 및 마크다운 링크 정규화로 verify 실패 수정#650
Conversation
verify가 두 가지 원인으로 FAIL하던 문제를 수정: 1. forward converter가 주입하는 confluenceUrl frontmatter 차이 → 비교 전 frontmatter strip 2. html_block 테이블 내 마크다운 링크가 정규화되지 않아 매핑 실패 → 링크 제거 규칙 추가 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_verify()에서 roundtrip 비교 전 양쪽 MDX의 frontmatter를 strip하여, forward converter가 주입하는confluenceUrl등 메타데이터 차이로 인한 false FAIL 제거_normalize_mdx_to_plain()에[text](url) → text규칙 추가하여, html_block 테이블 내 링크가 포함된 텍스트도 XHTMLget_text()와 올바르게 매핑되도록 수정근본 원인
confluenceUrlfrontmatter diffpage.v1.yaml에서 읽어 무조건 삽입 → reverse-sync 패칭 범위 밖_strip_frontmatter()헬퍼로 비교 전 제거html_block테이블 패치 누락_normalize_mdx_to_plain()이[text](url)패턴을 제거하지 않아 XHTML plain text와 불일치 → 매핑 실패변경 파일
confluence-mdx/bin/reverse_sync_cli.py—_strip_frontmatter()헬퍼 추가,run_verify()비교 전 strip 적용,_normalize_mdx_to_plain()링크 정규화 추가confluence-mdx/tests/test_reverse_sync_cli.py— 4개 테스트 추가Test plan
pytest tests/test_reverse_sync_cli.py— 37 passedpytest tests/— 175 passed, 1 pre-existing e2e failure (unrelated)reverse_sync_cli.py verify --branch jk/fix-typo-and-grammar --limit 5실행하여 실제 verify 결과 확인🤖 Generated with Claude Code