confluence-mdx: 코드 품질 리팩토링 3건 (함수 추출 + 테스트 추가)#803
Merged
Conversation
build_patches, build_table_row_patches, build_list_item_patches 3곳의 동일한 containing_changes 순회+패치 생성 로직을 헬퍼 함수로 통합합니다. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
build_patches() 루프 내부의 복잡한 매핑 해석 분기(순환 복잡도 ~12-15)를 별도 함수로 분리하여 strategy 기반 디스패치로 단순화합니다. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…_yaml, _compile_result를 추출합니다 151줄의 run_verify()에서 독립적인 3개 단계를 별도 함수로 분리하여 각 단계를 개별 테스트 가능하게 합니다. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
patch_builder.py의 3곳 중복containing_changes패턴을_flush_containing_changes()공통 함수로 추출합니다build_patches()루프의 매핑 해석 로직을_resolve_mapping_for_change()로 분리하여 순환 복잡도를 감소합니다reverse_sync_cli.py의run_verify()God Function에서_parse_and_diff(),_save_diff_yaml(),_compile_result()3개 함수를 추출합니다Test plan
🤖 Generated with Claude Code