fix(converter): 테이블 CJK display width 기반 컬럼 폭 계산을 수정합니다#975
Merged
Conversation
- `len()`은 CJK 문자를 1칸으로 계산하지만 실제로는 2칸 차지 - `_display_width()`: CJK 전각 문자(F, W)를 2칸으로 계산 - `_ljust_display()`: CJK 표시 폭 기준 좌측 정렬 - golden file 3건 및 sidecar 3건 재생성 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- isu_001 (confluence-mdx/bin/converter/core.py:1227): 테이블 패딩 계산을 바꾼 뒤 관련 렌더 골든을 함께 갱신하지 않아 CI가 깨집니다. 현재 변경으로 1454342158, 692355151, 793608206의 expected.mdx 출력이 달라졌지만 대응하는 expected.html은 그대로라서 Test Confluence MDX Converter와 로컬 make -C confluence-mdx/tests test-render-one TEST_ID=<case>가 모두 실패합니다. 영향을 받은 렌더 스냅샷도 같이 재생성해야 합니다.
- isu_003 (confluence-mdx/tests/test_forward_converter_known_bugs.py:3): ConfluenceToMarkdown이 import되었으나 테스트 코드에서 사용되지 않습니다. 불필요한 import를 제거하면 테스트 의도가 명확해집니다.
Contributor
Author
|
[debate-review][sha:1ec61fb3cf0bd032137a573d0d2bf77d483aa77c] Consensus reached after 4 rounds. Debate Summary
Applied Fixes
Withdrawn Findings
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
len()은 CJK 문자를 1칸으로 계산하지만, 터미널/렌더러에서는 2칸을 차지합니다._display_width()함수를 추가하여 CJK 전각 문자(East Asian Width F, W)를 2칸으로 계산합니다._ljust_display()함수를 추가하여 CJK 표시 폭 기준으로 셀을 좌측 정렬합니다._normalize_table_cell_padding으로 테이블 셀 패딩 공백 차이를 정규화하여 비교합니다.Added/updated tests?
test_forward_converter_known_bugs.pyCJK display width 테스트 추가🤖 Generated with Claude Code