Skip to content

Conversation

@quinnj
Copy link
Contributor

@quinnj quinnj commented Jul 7, 2019

…a bit

@codecov-io
Copy link

codecov-io commented Jul 7, 2019

Codecov Report

Merging #29 into master will decrease coverage by 0.16%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   79.91%   79.74%   -0.17%     
==========================================
  Files          19       19              
  Lines         473      474       +1     
==========================================
  Hits          378      378              
- Misses         95       96       +1
Impacted Files Coverage Δ
src/enumerable/enumerable.jl 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d7c6e3...0fbeadb. Read the comment docs.

@davidanthoff
Copy link
Member

Would it be enough to define just one method for Enumerable in https://github.com/queryverse/QueryOperators.jl/blob/master/src/enumerable/enumerable.jl? All the other ones inherit from that, so I think that should do the trick?

@quinnj
Copy link
Contributor Author

quinnj commented Jul 7, 2019

Updated

@davidanthoff davidanthoff merged commit 35eb87c into queryverse:master Jul 8, 2019
@davidanthoff
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants