Skip to content

ci(gitleaks): pin action to SHA and skip when license secret is missing#419

Merged
jerrinot merged 1 commit intomainfrom
jh_gitleaks-pin-hash-skip-forks
Apr 14, 2026
Merged

ci(gitleaks): pin action to SHA and skip when license secret is missing#419
jerrinot merged 1 commit intomainfrom
jh_gitleaks-pin-hash-skip-forks

Conversation

@jerrinot
Copy link
Copy Markdown
Contributor

Pin gitleaks/gitleaks-action to a full commit SHA (v2.3.9) instead of the mutable v2 tag, so a compromise of the upstream repo or tag can't silently change what runs in CI.

Skip the step when GITLEAKS_LICENSE is empty. Pull requests from forks don't receive org secrets, which was causing the check to fail on external contributor PRs (e.g. #390).

Pin gitleaks/gitleaks-action to a full commit SHA (v2.3.9) instead of
the mutable v2 tag, so a compromise of the upstream repo or tag can't
silently change what runs in CI.

Skip the step when GITLEAKS_LICENSE is empty. Pull requests from forks
don't receive org secrets, which was causing the check to fail on
external contributor PRs (e.g. #390).
@sklarsa sklarsa self-requested a review April 14, 2026 21:10
@github-actions
Copy link
Copy Markdown

🚀 Build success!

Latest successful preview: https://preview-419--questdb-documentation.netlify.app/docs/

Commit SHA: 83df4ff

📦 Build generates a preview & updates link on each commit.

@jerrinot jerrinot merged commit c104707 into main Apr 14, 2026
3 checks passed
@jerrinot jerrinot deleted the jh_gitleaks-pin-hash-skip-forks branch April 14, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants