Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,16 @@ cargo test test_name # single test
cargo test test_name -- --nocapture # with stdout
cargo fmt --check # format check
cargo fmt # format fix
cargo clippy -- -D warnings # lint (CI enforces -D warnings)
cargo clippy --all-targets # lint (no -D warnings — see "Fixing issues")
```

CI runs: fmt check, clippy with `-D warnings`, tests on both Ubuntu and macOS.
CI runs: fmt check, clippy, tests on both Ubuntu and macOS.

## Fixing issues

Fix every issue you encounter, even if it's pre-existing and unrelated to your current task — do not leave broken clippy lints, failing tests, fmt drift, or compiler warnings for a later PR. If CI is red because of a problem that exists on master, fix it here rather than skipping it. Scope creep from a few mechanical fixes is cheaper than a persistently red main branch.

`cargo clippy -- -D warnings` is not good enough — it only checks the default (bin) target. Always verify with `cargo clippy --all-targets -- -D warnings` so test-code lints are not missed, and fix anything it surfaces.
Do **not** pass `-D warnings` to clippy when you run it locally. Run plain `cargo clippy --all-targets` so warnings surface without aborting the build on the first hit — that lets you read the full list and fix them together. Every reported warning still needs to be fixed before the change lands, because CI does treat warnings as errors; "the command exited 0 without `-D`" is not a substitute for a clean warning-free output.

## Architecture

Expand Down
1 change: 1 addition & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ ignore = "0.4"
grep-regex = "0.1"
grep-searcher = "0.1"
grep-matcher = "0.1"
regex = "1"
parquet2 = { git = "https://github.com/questdb/parquet2", branch = "main" }
tar = "0.4"
flate2 = "1"
Expand Down
42 changes: 42 additions & 0 deletions src/action.rs
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,48 @@ pub enum Action {
// Help
ShowHelp,

// Parquet viewer
ParquetSearchOpen,
ParquetSearchChar(char),
ParquetSearchBackspace,
ParquetSearchAccept,
ParquetSearchCancel,
ParquetSearchNext,
ParquetSearchPrev,
ParquetCopyCell,
ParquetCopyRow,
ParquetPageLeft,
ParquetPageRight,
ParquetRowDetail,
ParquetExportCsv,
ParquetExportCsvAll,
ParquetNextRowGroup,
ParquetPrevRowGroup,
ParquetToggleSelect,
ParquetClearSelect,
ParquetCopyColumn,
ParquetColWiden,
ParquetColNarrow,
ParquetColReset,
ParquetColFreezeToggle,
ParquetCopyRowJson,
ParquetExportNdjson,
ParquetColHide,
ParquetColUnhideAll,
ParquetColFirst,
ParquetColLast,
ParquetColAutofit,
ParquetColInfo,
ParquetReload,
ParquetToggleThousands,
ParquetSelectAll,
ParquetInvertSelection,
ParquetSearchCurrentForward,
ParquetSearchCurrentBackward,
ParquetHalfPageUp,
ParquetHalfPageDown,
ParquetCycleSort,

// Menu
OpenMenu,

Expand Down
Loading
Loading