-
Notifications
You must be signed in to change notification settings - Fork 11
chore: dropped python 3.9 support, added python 3.14 and 3.14t support #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughRaises required Python to >=3.10, documents Python 3.14/3.14t support and removal of 3.9; adjusts cibuildwheel skip patterns; conditions a fastparquet import on Python <3.14 in CI install script; adds duplicate Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20–30 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2025-11-28T17:46:34.693ZApplied to files:
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
CHANGELOG.rst (1)
138-143: Consider moving this section out of "Bug fixes"."Python Version Support" describes version compatibility changes, not bug fixes. Consider placing it as a standalone subsection at the same level as "Bug fixes" and "Features", or rename to clarify it's a maintenance/infrastructure change.
That said, the content accurately documents the changes.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
CHANGELOG.rst(1 hunks)ci/pip_install_deps.py(1 hunks)pyproject.toml(1 hunks)test/test.py(1 hunks)
🔇 Additional comments (2)
pyproject.toml (1)
4-4: LGTM! Python version requirement correctly updated.The minimum Python version is now set to
>=3.10, aligning with the PR objective of dropping Python 3.9 (end of life) support.ci/pip_install_deps.py (1)
91-101: LGTM! Conditional fastparquet import for Python 3.14 compatibility.The guard correctly skips the fastparquet import verification on Python 3.14+ where the package is not yet available. The comment clearly explains this is a temporary measure.
286815e to
deceb89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
ci/run_tests_pipeline.yaml(2 hunks)
🔇 Additional comments (2)
ci/run_tests_pipeline.yaml (2)
91-95: Verify uv--pythonsyntax and test class reference.Two concerns:
- The
--python pythonsyntax appears unusual—typically you'd specify a version (e.g.,--python 3.10). Please verify this is correct and aligns with your uv version and documentation.- The AI summary mentions a new
TestBufferProtocolVersionV3test class was added, but these commands still referenceTestBufferProtocolVersionV2. Confirm whether the test class reference is outdated or intentional.
109-109: Python 3.11 for numpy 2.x tests and uv syntax consistency.The numpy 2.x test job uses Python 3.11, which is reasonable. However, the same concerns about
--python pythonsyntax and test class reference (V2 vs V3) from the 1.x test job apply here as well. Additionally, consider whether Python 3.14/3.14t should be tested with the newer numpy 2.x versions.Also applies to: 115-119
Summary by CodeRabbit
Documentation
Chores
Tests
✏️ Tip: You can customize this high-level summary in your review settings.