feat: test decimal #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ideoma
reviewed
Oct 13, 2025
| ], | ||
| "result": { | ||
| "status": "SUCCESS", | ||
| "line": "decimals zero=0d,neg_zero=0d,one=1.0d,large=99999999999999.999d,small=0.001d,neg_small=-0.001d", |
Collaborator
There was a problem hiding this comment.
Any programming language where d suffix means decimal and not double?
Author
There was a problem hiding this comment.
I don't know of one, but ILP isn't a programming language and m was already used for millisecond timestamps. Also, there is no reason d would be used for doubles in the future as any numeric literals are doubles by default.
Collaborator
There was a problem hiding this comment.
d is confusing; I'd rather have any other unused letter. Type suffixes in ILP work when a new column has to be created; they determine the column type.
Author
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new test to validate decimal serialization in both text (v1) and binary (v2) formats.
Tandem with: