-
Notifications
You must be signed in to change notification settings - Fork 9
Add support for QuestDB's LIMIT clause in SQLAlchemy dialect #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Key features: - Standard LIMIT N syntax - LIMIT lower,upper range syntax (lower exclusive, upper inclusive) - Support for expressions and bind parameters - Automatic conversion of SQLAlchemy's LIMIT/OFFSET Example: select(table).limit(5) # LIMIT 5 select(table).limit(3).offset(2) # LIMIT 2,5 select(table).offset(8) # LIMIT 8,BIGINT_MAX
435aa17 to
0e3eeaa
Compare
|
Anything I can to do help move this one along? I have a use-case where I need the OFFSET to work with Superset and I just noticed this PR. I might try to experiment with it myself and confirm it resolves that problem, but there is a very real need for translating OFFSET to LIMIT for QuestDB. In the case of Superset, they use it for more efficient server side pagination, and they use it for pagination with their "drill down" mode when exploring data behind a chart, etc. |
|
Just to confirm, I installed this branch into my venv for my Superset installation, and it worked like a charm!! Now I am looking forward to see it merged. It has enabled server side pagination and drill down for me. :D |
|
@nwoolmer Is there anything I could do to help here? Not sure I have the bandwidth, but without a solution for OFFSET/LIMIT in the SQLAlchemy connector for QuestDB, we cannot make use of server side pagination and other features where Superset requires support for the LIMIT clause. See issue #29 for details. |
|
I'll raise it! |
|
@cardilloscreations Sorry for the delay on this one, aiming for a release Monday :) |
|
@nwoolmer Awesome! Thanks! :D |
|
@cardilloscreations: just FYI - the newly released 1.1.4 contains this fix. |
Implements QuestDB's LIMIT clause in SQLAlchemy dialect. Key features:
Example:
This addressed the 2nd bullet from #25