fix(ui): Fix select build() being called repeatedly#2217
Merged
Conversation
insmac
added
Bug
ideoma
approved these changes
Jun 13, 2022
argshook
pushed a commit
to questdb/ui
that referenced
this pull request
Jun 14, 2022
Vaibhav91one
pushed a commit
to Vaibhav91one/ui
that referenced
this pull request
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix
The main purpose of this PR is to fix an issue wherein
select build()is fired repeatedly upon resizing panels (caused by the side effect hook being called on each re-render).Side changes
Instead of copying to clipboard, the button now links to either release notes (when using a ready-made version) or commit hash (i.e. on a custom local build).
Release info:
Custom build info:
