chore(qwp): exclude dropped datagrams from processedCount#7168
Merged
Conversation
drainReceiver() in the malformed-datagram tests polls on processedCount + totalDroppedCount. Bumping processedCount on drops double-counted them, letting drainReceiver return one datagram short and pass even when a trailing valid datagram never arrived. processDatagram() now returns a DATAGRAM_DROPPED flag on the four error paths, and both runSerially() callers skip the processedCount++ when it is set. this stabilizes a flaky testTooShortElevenBytes()
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jerrinot
added
the
Flaky Test
Contributor
[PR Coverage check]😍 pass : 8 / 8 (100.00%) file detail
|
bluestreak01
approved these changes
May 27, 2026
RaphDal
pushed a commit
that referenced
this pull request
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
drainReceiver() in the malformed-datagram tests polls on processedCount + totalDroppedCount. Bumping processedCount on drops double-counted them, letting drainReceiver return one datagram short and pass even when a trailing valid datagram never arrived.
processDatagram() now returns a DATAGRAM_DROPPED flag on the four error paths, and both runSerially() callers skip the processedCount++ when it is set.
this stabilizes a flaky testTooShortElevenBytes()