chore(): Reformat lint to account for future subdirs#25
Closed
oliver-daniel wants to merge 3 commits intomasterfrom
Closed
chore(): Reformat lint to account for future subdirs#25oliver-daniel wants to merge 3 commits intomasterfrom
oliver-daniel wants to merge 3 commits intomasterfrom
Conversation
This was referenced Aug 15, 2023
Merged
Member
|
does not work on windows due to single quoting the pattern:
|
Contributor
|
@oliver-daniel is this PR still relevant? |
Author
|
Probably not. Vlad and I were pair-programming on getting a minor fix pushed through, and we ended up with divergent behaviour with my being on *nix and him on Windows. |
Contributor
|
okay, thanks for updating! I'll close the PR then. Feel free to reopen if anything will change. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just doing everything as a PR to avoid accidents.