Skip to content

chore(web-console): allow editing column types on existing tables #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
insmac merged 5 commits into from
May 17, 2023
Merged

chore(web-console): allow editing column types on existing tables #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bf885d7
Allow editing column types on existing tables
insmac May 15, 2023
f363c34
Remove unnecessary info
insmac May 15, 2023
3539cf5
Enable geohash precision input
insmac May 16, 2023
e69d262
Change designated timestamp button
insmac May 17, 2023
aeb34fd
Merge branch 'main' into web-console/allow-edits
insmac May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions packages/web-console/src/scenes/Import/ImportCSVFiles/table-schema/column.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ export const Column = ({
</Form.Item>
<Form.Item name={`schemaColumns.${index}.type`} label="Type">
<Form.Select
disabled={isEditLocked}
defaultValue={column.type}
name={`schemaColumns.${index}.type`}
options={supportedColumnTypes}
Expand All @@ -122,13 +121,13 @@ export const Column = ({
<IconWithTooltip
icon={
<Button
disabled={type !== "TIMESTAMP" || isEditLocked}
disabled={column.type !== "TIMESTAMP"}
skin={
timestamp !== "" &&
column.name !== "" &&
timestamp === column.name
? "success"
: "transparent"
: "secondary"
}
onClick={() => {
onSetTimestamp(column.name)
Expand Down Expand Up @@ -161,7 +160,6 @@ export const Column = ({
helperText="Required when using the TIMESTAMP type"
>
<Form.Input
disabled={isEditLocked}
name={`schemaColumns.${index}.pattern`}
placeholder={DEFAULT_TIMESTAMP_FORMAT}
defaultValue={
Expand All @@ -188,7 +186,6 @@ export const Column = ({
}
>
<Form.Input
disabled={isEditLocked}
name={`schemaColumns.${index}.precision`}
required
/>
Expand Down
10 changes: 0 additions & 10 deletions packages/web-console/src/scenes/Import/ImportCSVFiles/table-schema/columns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,16 +127,6 @@ export const Columns = ({

return (
<>
{isEditLocked && (
<Disclaimer isEditLocked={true}>
<Alert size="20px" />
<Text color="orange">
Schema is read-only when importing to an existing table.
<br />
To edit, change the target table name and try again.
</Text>
</Disclaimer>
)}
{!isEditLocked && (
<Disclaimer isEditLocked={false}>
<Information size="20px" />
Expand Down