Skip to content

chore(web-console): Deprecate durable upload setting #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bluestreak01 merged 1 commit into from
Aug 15, 2023
Merged

chore(web-console): Deprecate durable upload setting #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/web-console/src/scenes/Import/ImportCSVFiles/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ export const ImportCSVFiles = ({ onImported }: Props) => {
skipLev: false,
delimiter: "",
atomicity: "skipCol",
durable: false,
maxUncommitedRows: MAX_UNCOMMITTED_ROWS,
},
isUploading: false,
Expand Down
15 changes: 0 additions & 15 deletions packages/web-console/src/scenes/Import/ImportCSVFiles/upload-settings-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ export const UploadSettingsDialog = ({
forceHeader,
skipLev,
atomicity,
durable,
maxUncommitedRows,
} = file.settings

Expand All @@ -94,7 +93,6 @@ export const UploadSettingsDialog = ({
forceHeader,
skipLev,
atomicity,
durable,
maxUncommitedRows,
}

Expand Down Expand Up @@ -190,19 +188,6 @@ export const UploadSettingsDialog = ({
),
defaultValue: settings.skipLev,
},
{
type: "switch",
name: "durable",
label: "Durable",
description: (
<>
When set to <strong>true</strong>, import will be resilient against OS
errors or power losses by forcing the data to be fully persisted
before sending a response back to the user.
</>
),
defaultValue: settings.durable,
},
]

return (
Expand Down
1 change: 0 additions & 1 deletion packages/web-console/src/utils/questdb.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@ export type UploadModeSettings = {
skipLev: boolean
delimiter: string
atomicity: string
durable: boolean
maxUncommitedRows: number
}

Expand Down