Skip to content

chore(web-console): support writing multiple files to the same target#192

Merged
insmac merged 2 commits intomainfrom
web-console/fix-import-table-names
Sep 8, 2023
Merged

chore(web-console): support writing multiple files to the same target#192
insmac merged 2 commits intomainfrom
web-console/fix-import-table-names

Conversation

@insmac
Copy link
Copy Markdown
Contributor

@insmac insmac commented Aug 30, 2023

Allow writing to the same target table name from different files.

This PR makes sure each file added to the queue is treated as a separate entity and there are no glitches in the UI.

CleanShot.2023-08-30.at.10.15.56.mp4

@insmac insmac added the web-console Issues relevant to "web-console" package label Aug 30, 2023
Comment thread packages/web-console/src/scenes/Import/ImportCSVFiles/utils.ts
Copy link
Copy Markdown
Contributor

@jerrinot jerrinot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the change locally, it does what the PR says.
I get the idea behind the change - generate unique IDs. but I am far from a front-ent expert to say it's the best possible solution. but it looks good to me.

I stumbled upon another weirdness while importing a CSV, but that's unrelated to this PR and it's very likely caused by a server-side bug. I'm investigating that separately.

@insmac insmac merged commit 90c5f40 into main Sep 8, 2023
@insmac insmac deleted the web-console/fix-import-table-names branch September 8, 2023 15:52
Vaibhav91one pushed a commit to Vaibhav91one/ui that referenced this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web-console Issues relevant to "web-console" package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants