Skip to content

fix(grid): fix render crash when grid is empty #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
insmac merged 2 commits into from
Sep 12, 2023
Merged

fix(grid): fix render crash when grid is empty #198

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1313c35
fix(grid): render crash when grid is empty
bluestreak01 Sep 12, 2023
41f566e
fix(grid): fix grid render for empty result set & no data
bluestreak01 Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/web-console/src/js/console/grid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1312,7 +1312,20 @@ export function grid(rootElement, _paginationFn, id) {
viewport.scrollTop = viewportLeft.scrollTop
}

function noData() {
if (data.length === 0) {
return true
}
return data[0].length === 0;
}

function render() {
if (noData()) {
renderColumns()
renderRows(0)
return;
}

// If viewport is invisible when grid is updated it is not possible
// to calculate column width correctly. When grid becomes visible again, resize()
// is called where we continue calculating column widths. resize() can also be
Expand Down