Skip to content

Fix showTables for Backwards Compatibility with name Property in QuestDB#213

Merged
marregui merged 1 commit intomainfrom
web-console/backwards-compatible-table-name
Oct 24, 2023
Merged

Fix showTables for Backwards Compatibility with name Property in QuestDB#213
marregui merged 1 commit intomainfrom
web-console/backwards-compatible-table-name

Conversation

@argshook
Copy link
Copy Markdown
Contributor

PR Description

This PR includes a fix for the showTables function to ensure backwards compatibility with the name property. The upcoming versions of QuestDB will change the column name from name to table_name for the tables() query.

The web console has already started using the table_name property, but it's crucial to maintain compatibility with older versions of QuestDB.

Please note that this backwards compatibility code can be removed once the new version of QuestDB is released.

Commit log:

  • fix showTables to be backwards compatible with name property
    Upcoming QuestdB versions will change the column name from name -> table_name for tables() query.

    The web console is already using table_name property, but it should be backwards compatible with older versions of QuestDB.

    Once the new version of QuestDB is released, we can remove this
    backwards compatible code.

Upcoming QuestdB versions will change the column name from `name` -> `table_name` for `tables()` query.

The web console is already using `table_name` property, but it should be backwards compatible with older versions of QuestDB.

Once the new version of QuestDB is released, we can remove this
backwards compatible code.
@argshook argshook self-assigned this Oct 24, 2023
Copy link
Copy Markdown
Contributor

@marregui marregui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marregui marregui merged commit 6182010 into main Oct 24, 2023
@marregui marregui deleted the web-console/backwards-compatible-table-name branch October 24, 2023 15:48
Vaibhav91one pushed a commit to Vaibhav91one/ui that referenced this pull request Oct 28, 2025
…QuestDB (questdb#213)

fix `showTables` to be backwards compatible with `name` property

Upcoming QuestdB versions will change the column name from `name` -> `table_name` for `tables()` query.

The web console is already using `table_name` property, but it should be backwards compatible with older versions of QuestDB.

Once the new version of QuestDB is released, we can remove this
backwards compatible code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants