feat(web-console): update pane splitters to real time#220
Merged
bluestreak01 merged 14 commits intomainfrom Nov 13, 2023
Merged
feat(web-console): update pane splitters to real time#220bluestreak01 merged 14 commits intomainfrom
bluestreak01 merged 14 commits intomainfrom
Conversation
bluestreak01
approved these changes
Nov 13, 2023
Member
bluestreak01
left a comment
bluestreak01
left a comment
There was a problem hiding this comment.
wow, the new splitters are epic! Great job @insmac !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current splitter implementation is not flexible enough for the upcoming Import UI update. The new solution, Allotment, is derived from the VS Code core codebase, allowing for far bigger flexibility.
This also fixes issues with the older splitter (i.e. jumping after drag end etc).
Screen recording:
CleanShot.2023-11-10.at.17.08.30.mp4