Skip to content

Do not duplicate existing queries when appending via URL param#33

Merged
argshook merged 5 commits intomainfrom
fix-append-query-dupes
Sep 28, 2022
Merged

Do not duplicate existing queries when appending via URL param#33
argshook merged 5 commits intomainfrom
fix-append-query-dupes

Conversation

@insmac
Copy link
Copy Markdown
Contributor

@insmac insmac commented Sep 26, 2022

Detect if a query passed via URL param already exists in the editor buffer and instead of duplicating, highlight the first match.

Tests - to be added

CleanShot 2022-09-26 at 19 44 21@2x

Comment thread packages/web-console/src/scenes/Editor/Monaco/index.tsx Outdated
no need as `URLSearchParams.prototype.get` already decodes string
@argshook argshook merged commit 37b9dc2 into main Sep 28, 2022
@argshook argshook deleted the fix-append-query-dupes branch September 28, 2022 11:13
insmac added a commit to questdb/questdb that referenced this pull request Sep 28, 2022
### Added

- Improve visual cues in the query editor. Highlighting active query with green bar, erroneous query with red dot and add run button. [#34](questdb/ui#34)

### Fixed

- fix duplication issue when loading web console with `?query=some sql&executeQuery=true` multiple time [#33](questdb/ui#33)
Vaibhav91one pushed a commit to Vaibhav91one/ui that referenced this pull request Oct 28, 2025
… param (questdb#33)

* Do not duplicate existing queries when appending

* Fix conditional

* add test

* remove `.replaceAll`

no need as `URLSearchParams.prototype.get` already decodes string

* add changelog entry

Co-authored-by: argshook <argshook@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants