fix(web console): handling comments in SQL editor highlights#336
Merged
bluestreak01 merged 7 commits intomainfrom Oct 7, 2024
Merged
fix(web console): handling comments in SQL editor highlights#336bluestreak01 merged 7 commits intomainfrom
bluestreak01 merged 7 commits intomainfrom
Conversation
bluestreak01
changed the title
bluestreak01
approved these changes
Oct 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issues with query highlighting where line comments are in place - most importantly before the statement, like so:
This should work when the comment contains the actual text after the
--mark, as well as it's empty (--only).