Skip to content

fix(web-console): tab state update issues that lead to visual side effects #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bluestreak01 merged 7 commits into from
Oct 7, 2024
Merged

fix(web-console): tab state update issues that lead to visual side effects #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2781a22
fix(web-console): tab state update issues that lead to visual side ef…
bluestreak01 Oct 4, 2024
238a525
submodule update
insmac Oct 4, 2024
e86f624
Merge remote-tracking branch 'origin/main' into vi_fix_tabs
bluestreak01 Oct 4, 2024
8d1e1ad
fix tab add
bluestreak01 Oct 4, 2024
78d78ee
something works, something doesn't
bluestreak01 Oct 4, 2024
6098259
reorder methods
bluestreak01 Oct 4, 2024
33948bb
Merge remote-tracking branch 'origin/main' into vi_fix_tabs
bluestreak01 Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/web-console/src/components/ReactChromeTabs/chrome-tabs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ import Draggabilly from "draggabilly"
const TAB_CONTENT_MARGIN = 10
const TAB_CONTENT_OVERLAP_DISTANCE = 1

const TAB_OVERLAP_DISTANCE =
TAB_CONTENT_MARGIN * 2 + TAB_CONTENT_OVERLAP_DISTANCE

const TAB_CONTENT_MIN_WIDTH = 24
const TAB_CONTENT_MAX_WIDTH = 240

Expand Down Expand Up @@ -64,7 +61,7 @@ const tabTemplate = `
<div class="chrome-tab">
<div class="chrome-tab-dividers"></div>
<div class="chrome-tab-background">
<svg version="1.1" xmlns="http://www.w3.org/2000/svg"><defs><symbol id="chrome-tab-geometry-left" viewBox="0 0 214 36"><path d="M17 0h197v36H0v-2c4.5 0 9-3.5 9-8V8c0-4.5 3.5-8 8-8z"/></symbol><symbol id="chrome-tab-geometry-right" viewBox="0 0 214 36"><use xlink:href="#chrome-tab-geometry-left"/></symbol><clipPath id="crop"><rect class="mask" width="100%" height="100%" x="0"/></clipPath></defs><svg width="52%" height="100%"><use xlink:href="#chrome-tab-geometry-left" width="214" height="36" class="chrome-tab-geometry"/></svg><g transform="scale(-1, 1)"><svg width="52%" height="100%" x="-100%" y="0"><use xlink:href="#chrome-tab-geometry-right" width="214" height="36" class="chrome-tab-geometry"/></svg></g></svg>
<svg xmlns="http://www.w3.org/2000/svg"><defs><symbol id="chrome-tab-geometry-left" viewBox="0 0 214 36"><path d="M17 0h197v36H0v-2c4.5 0 9-3.5 9-8V8c0-4.5 3.5-8 8-8z"/></symbol><symbol id="chrome-tab-geometry-right" viewBox="0 0 214 36"><use xlink:href="#chrome-tab-geometry-left"/></symbol><clipPath id="crop"><rect class="mask" width="100%" height="100%" x="0"/></clipPath></defs><svg width="52%" height="100%"><use xlink:href="#chrome-tab-geometry-left" width="214" height="36" class="chrome-tab-geometry"/></svg><g transform="scale(-1, 1)"><svg width="52%" height="100%" x="-100%" y="0"><use xlink:href="#chrome-tab-geometry-right" width="214" height="36" class="chrome-tab-geometry"/></svg></g></svg>
</div>
<div class="chrome-tab-content">
<div class="chrome-tab-favicon"></div>
Expand Down Expand Up @@ -392,7 +389,6 @@ class ChromeTabs {

updateTab(tabEl: HTMLElement, tabProperties: TabProperties) {
tabEl.setAttribute("data-tab-title", tabProperties.title)
tabEl.setAttribute("title", tabProperties.title)
tabEl.querySelector(".chrome-tab-title")!.textContent = tabProperties.title
const input = tabEl.querySelector(".chrome-tab-rename")!
input.setAttribute("value", tabProperties.title)
Expand Down
1 change: 0 additions & 1 deletion packages/web-console/src/components/ReactChromeTabs/hooks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import React, {
forwardRef,
useCallback,
useEffect,
useMemo,
useRef,
} from "react"
import ChromeTabsClz, { TabProperties } from "./chrome-tabs"
Expand Down
1 change: 0 additions & 1 deletion packages/web-console/src/scenes/Editor/Monaco/tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ export const Tabs = () => {
newTabs.forEach(async (tab, index) => {
await updateBuffer(tab.id as number, { position: index })
})
await setActiveBuffer(newTabs[toIndex])
}

const rename = async (id: string, title: string) => {
Expand Down