Skip to content

feat(web-console): change upload.tsx wording to clarify how to enable copy #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
insmac merged 1 commit into from
Oct 21, 2024
Merged

feat(web-console): change upload.tsx wording to clarify how to enable copy #347

insmac merged 1 commit into from
Oct 21, 2024

Conversation

@smv1256
Copy link
Contributor

@smv1256 smv1256 commented Oct 19, 2024 •
edited
Loading

This explicitly clarifies where to refer to enable COPY, per issue #286.

when CSV root is not set then webconsole shows this note:
image
It should also hint how to enable it. chances are the link behind COPY SQL shows that, but the note should be explicit about it. something to indicate "here is how you fix it". Perhaps something like a link with words "Enable it" would do the trick.

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@smv1256 smv1256 changed the title Update upload.tsx to hint how to enable copy refactor: update upload.tsx wording to hint how to enable copy Oct 19, 2024
@smv1256 smv1256 changed the title refactor: update upload.tsx wording to hint how to enable copy feat: update upload.tsx wording to hint how to enable copy Oct 19, 2024
@smv1256 smv1256 changed the title feat: update upload.tsx wording to hint how to enable copy feat: change upload.tsx wording to clarify how to enable copy Oct 19, 2024
@smv1256 smv1256 changed the title feat: change upload.tsx wording to clarify how to enable copy feat(web-console): change upload.tsx wording to clarify how to enable copy Oct 19, 2024
@insmac insmac merged commit e4c8d6b into questdb:main Oct 21, 2024
@insmac insmac mentioned this pull request Oct 23, 2024
Merged
@emrberk emrberk mentioned this pull request Jul 7, 2025
Closed
Vaibhav91one pushed a commit to Vaibhav91one/ui that referenced this pull request Oct 28, 2025
@smv1256
feat(web-console): change upload.tsx wording to clarify how to enable…
e8ecbe3 
… copy (questdb#347)

Update upload.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@insmac insmac insmac approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smv1256 @CLAassistant @insmac