Skip to content

fix(ui): prevent login loop when token expires without a valid refresh token#395

Merged
nwoolmer merged 9 commits intomainfrom
auth_payload_clear_on_logout
Feb 13, 2025
Merged

fix(ui): prevent login loop when token expires without a valid refresh token#395
nwoolmer merged 9 commits intomainfrom
auth_payload_clear_on_logout

Conversation

@glasstiger
Copy link
Copy Markdown
Contributor

@glasstiger glasstiger commented Feb 7, 2025

When the access token expires, and there is no refresh token, it is not enough to send the user to the logout screen.
We also have to clear the expired token from local storage.

This PR also adds QuestDB Enterprise tests to web console.
Started off with OIDC integration tests by mocking the OAuth2 provider endpoints.
The test framework is just a starter, can be improved later.
We will also have to create a github workflow to run the tests as part of the build.

@glasstiger glasstiger marked this pull request as draft February 7, 2025 17:26
@glasstiger glasstiger marked this pull request as ready for review February 12, 2025 03:38
@nwoolmer
Copy link
Copy Markdown
Contributor

We can circle back for CI.

@nwoolmer nwoolmer merged commit 901e9e3 into main Feb 13, 2025
@nwoolmer nwoolmer deleted the auth_payload_clear_on_logout branch February 13, 2025 16:19
Vaibhav91one pushed a commit to Vaibhav91one/ui that referenced this pull request Oct 28, 2025
…h token (questdb#395)

* fix(ui): prevent login loop when token expires without a valid refresh token

* update submodule

* ent oidc tests - WIP

* ent oidc tests - WIP

* ent oidc tests - WIP

* ent oidc tests - WIP

* ent oidc tests

* update submodule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants