chore(web-console): minor improvements to tests and performance #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 13, 2025
goodroot
force-pushed
the
kellen/pr-cleanup
branch
from
ed3bbff to
1933954
Compare
This was referenced Mar 13, 2025
This reverts commit 1933954.
chore(web-console): reduce chart re-rendering
The current version of Metrics re-renders the charts more than it's needed due to how the method to generate the uPlot configuration object is executed. This PR ensures each chart widget is rendered one time per refresh cycle. This can be verified by putting on a logger in the onCreate method of the uPlot component.
Changes:
Convert useGraphOptions to a method that is no longer a React hook, since there is no need to get the theme context in there anymore.
Refresh the uPlot configuration object only when the data is changed (= per refresh cycle).
emrberk
force-pushed
the
kellen/pr-cleanup
branch
from
a67740f to
73c5c1c
Compare
emrberk
approved these changes
Apr 4, 2025
Vaibhav91one
pushed a commit
to Vaibhav91one/ui
that referenced
this pull request
Oct 28, 2025
…tdb#406) * folds questdb#344 chore(browser-tests): stabilize CI * folds questdb#345 chore(browser-tests): Add Cypress Cloud config needs testing, may remove * Revert "folds questdb#345" This reverts commit 1933954. * folds questdb#388 * folds questdb#389 chore(web-console): reduce chart re-rendering The current version of Metrics re-renders the charts more than it's needed due to how the method to generate the uPlot configuration object is executed. This PR ensures each chart widget is rendered one time per refresh cycle. This can be verified by putting on a logger in the onCreate method of the uPlot component. Changes: Convert useGraphOptions to a method that is no longer a React hook, since there is no need to get the theme context in there anymore. Refresh the uPlot configuration object only when the data is changed (= per refresh cycle). * change filename to match * cleanup test changes * add missing import * update submodule --------- Co-authored-by: emrberk <emreberk5699@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR combines completed but unmerged PRs into a small bundle for testing and tidiness.
CI efficiency chore(browser-tests): stabilize CI #344
Performance