fix(web-console): prevent infinite state updates in metrics#469
Merged
fix(web-console): prevent infinite state updates in metrics#469
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes infinite state update loops in the Metrics component by reworking state management to eliminate redundant local state and ensure all updates go through the updateBuffer call.
- Removed local state variables and replaced them with direct access to buffer state
- Eliminated redundant effects that were causing infinite loops between local and context state
- Fixed visibility check implementation to properly set ref when telemetry is enabled
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/web-console/src/scenes/Editor/index.tsx | Added key prop to Metrics component to force remount on buffer changes |
| packages/web-console/src/scenes/Editor/Metrics/index.tsx | Removed local state management, fixed infinite update loops, and streamlined state synchronization |
| packages/browser-tests/questdb | Updated subproject commit reference |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Vaibhav91one
pushed a commit
to Vaibhav91one/ui
that referenced
this pull request
Oct 28, 2025
) * fix(web-console): prprevent infinite state updates in metrics * submodule * Update packages/web-console/src/scenes/Editor/Metrics/index.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * copilot mess --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworked the state management of this component, ensuring updates all go through the
updateBuffercall, no redundant local state, no unnecessary rerenders, no mutations on context values.