Skip to content

fix: remove implicit select suggestions filtering, context-aware function suggestions#556

Merged
emrberk merged 8 commits into
mainfrom
fix/implicit-select-and-functions
May 7, 2026
Merged

fix: remove implicit select suggestions filtering, context-aware function suggestions#556
emrberk merged 8 commits into
mainfrom
fix/implicit-select-and-functions

Conversation

@emrberk
Copy link
Copy Markdown
Collaborator

@emrberk emrberk commented Apr 21, 2026

Related parser commit: questdb/sql-parser@5a422b0

Summary

Bumps @questdb/sql-parser from 0.1.8 to 0.1.11 — autocomplete now picks function categories from the cursor's grammar context instead of dumping the full function list at every identifier position, implicit select statements suggestions are included in the statement start.
Fixes hanging editor when there is a trailing comma in the select list.

Adds manual resolutions for lodash and lodash-es to version 4.18.1 to resolve vulnerability scan issues

Examples

t|

  • Before: Not suggesting any tables
  • After: Suggests trades (if table exists), tables, wal_tables etc.

SELECT * FROM trades ASOF JOIN m|

  • Before: 332 entries — materialized_views, maxUncommittedRows, max, median, mid, millis, min, …
  • After: 3 entries — materialized_views, memory_metrics, table_writer_metrics

SELECT * FROM trades WHERE price = c|

  • Before: scalars + aggregates mixed (coalesce, count, count_distinct, corr, covar_*, …)
  • After: scalars only (coalesce, concat, cos, ceil)

INSERT INTO trades VALUES (n|

  • Before: 0 suggestions
  • After: now, now_ns, nullif, nanos, netmask

@emrberk emrberk requested a review from bluestreak01 April 21, 2026 11:19
Copy link
Copy Markdown

@javier javier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still get some weird results from postgresql meta functions

Image

Also, not sure if intended behaviour, but when I search from some letter and I have partial results, I get partial results only if the letter is at the beginning of a word (beginning of word, after period, after underscore), but not if the letter is midword

Copy link
Copy Markdown

@javier javier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the opposite behaviour to what described for aggregates. This is on older version from main

Image

and this is in newer version from this PR

Image

@emrberk emrberk merged commit ce61798 into main May 7, 2026
4 checks passed
@emrberk emrberk deleted the fix/implicit-select-and-functions branch May 7, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants