pw64_filesys_dump: add ADAT/DATA string decoding#3
Merged
queueRAM merged 1 commit intoqueueRAM:masterfrom Sep 21, 2019
Merged
Conversation
Owner
|
I may change some of the string hex matching to numeric matching, but otherwise looks good. Thanks for decoding these strings! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will allow you to see the strings used in various places throughout the game.
Right now the output format looks like this:
You can disable the hex output and just have the text if you comment out one line.
Let me know if this format is OK or if anything should be changed.
The whole decoding code can probably be done cleaner but I think this is a good start. There are still some things that need fixing (like "unknown" characters/codes).