Conditional Refactor Replay#10
Merged
Merged
Conversation
Execution now almost entirely handled by conditionals. Many minor bug fixes. Added a 'debugtree' to OttoBase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replayed commits from conditional_refactor here.
Original PR:
Biiiig changes.
ExampleInterpreter bug fixes (tons)
Reorganized classes for more considtency
Moved most of what was in BaseVocab into OttoBase for cleaner inheritance.
Added child_parsers class method to OttoBase
Added a debugtree method to ottobase for easier debugging (more work needed here)
Conditionals now directly control their own evaluation AND command execution logic for more flexible control
Added IfThenElse class which supports nested if statements and (predictably) and else statement.