Otto cleaner#26
Merged
Merged
Conversation
Split interpreter into smaller parts. Pass pieces to OttoContext.
Input class now handles most of the var/entity parsing and evaluation so commands don't have to think about it. "value" renamed to _value. Classes should never call .value except on themselves. Slight rework of Command class to allow setting of static kwargs more easily. ExampleInterpreter removed entirely
Also started linting parser_definitions for better readability.
Triggers now return a flat list of dictionaries.
To avoid annoying pytest
Removed old 'fetch' argument. Var attributes now correctly handle entities Added a copy function to ottobase. Otto classes now store a copy of their parse results so they can 'recreate' themselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large refactoring of class APIs for more maintainable code
Implemented tests across most classes.
Language features now highly consistent (of course, bugs may remain).