CCL bugfix with new blocking interface#1005
Merged
Merged
Conversation
… changes Signed-off-by: Kushal Dulla <quic_kdulla@quicinc.com>
Signed-off-by: Kushal Dulla <kdulla@qti.qualcomm.com>
quic-mohmeh
pushed a commit
to quic-mohmeh/efficient-transformers
that referenced
this pull request
May 25, 2026
Previous changes to non-blocked attention forward were causing the attention mask generated for CCL to not be correct in the standard attention forward. Returned the updated attention mask from the past_key_value_update helper function in order to fix this. --------- Signed-off-by: Kushal Dulla <quic_kdulla@quicinc.com> Signed-off-by: Kushal Dulla <kdulla@qti.qualcomm.com> Signed-off-by: Mohit Mehta <mohmeh@qti.qualcomm.com>
smedhe
pushed a commit
to smedhe/QEff_Sharvari
that referenced
this pull request
May 25, 2026
Previous changes to non-blocked attention forward were causing the attention mask generated for CCL to not be correct in the standard attention forward. Returned the updated attention mask from the past_key_value_update helper function in order to fix this. --------- Signed-off-by: Kushal Dulla <quic_kdulla@quicinc.com> Signed-off-by: Kushal Dulla <kdulla@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous changes to non-blocked attention forward were causing the attention mask generated for CCL to not be correct in the standard attention forward. Returned the updated attention mask from the past_key_value_update helper function in order to fix this.