[WIP] Fix for acc issue in Qwen3 VL moe#1010
Merged
quic-rishinr merged 3 commits intoJun 2, 2026
Merged
Conversation
Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com>
|
|
||
| return local_this | ||
| visual_mask = visual_pos_masks.to(hidden_states.dtype) | ||
| return hidden_states + (visual_embeds * visual_mask) |
Contributor
There was a problem hiding this comment.
It looks to be compiler ambiguity during interpretation.
quic-hemagnih
approved these changes
May 26, 2026
Contributor
Author
|
Logs : Pr_1010_validation_logs.txt |
Contributor
|
Let's rebase and close this @tv-karthikeya @quic-rishinr |
Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com>
quic-rishinr
added a commit
that referenced
this pull request
Jun 2, 2026
This reverts commit 63e2c29. Signed-off-by: Rishin Raj <rishinr@qti.qualcomm.com>
quic-rishinr
added a commit
that referenced
this pull request
Jun 2, 2026
Reverts #1010 Signed-off-by: Rishin Raj <rishinr@qti.qualcomm.com>
tchawada
pushed a commit
to tchawada/QEff_tanisha
that referenced
this pull request
Jun 2, 2026
Issue: Generated text is not accurate (unable to identify object in given image) 5/25: Found a workaround, seems like compiler issue - debugging further --------- Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com>
tchawada
pushed a commit
to tchawada/QEff_tanisha
that referenced
this pull request
Jun 2, 2026
Reverts quic#1010 Signed-off-by: Rishin Raj <rishinr@qti.qualcomm.com>
tchawada
pushed a commit
to tchawada/QEff_tanisha
that referenced
this pull request
Jun 2, 2026
Issue: Generated text is not accurate (unable to identify object in given image) 5/25: Found a workaround, seems like compiler issue - debugging further --------- Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com> Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
tchawada
pushed a commit
to tchawada/QEff_tanisha
that referenced
this pull request
Jun 2, 2026
Reverts quic#1010 Signed-off-by: Rishin Raj <rishinr@qti.qualcomm.com> Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
quic-rishinr
pushed a commit
to tchawada/QEff_tanisha
that referenced
this pull request
Jun 3, 2026
Issue: Generated text is not accurate (unable to identify object in given image) 5/25: Found a workaround, seems like compiler issue - debugging further --------- Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com> Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
quic-rishinr
added a commit
to tchawada/QEff_tanisha
that referenced
this pull request
Jun 3, 2026
Reverts quic#1010 Signed-off-by: Rishin Raj <rishinr@qti.qualcomm.com> Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
vaibverm
pushed a commit
to vaibverm/efficient-transformers-blocking-techniques
that referenced
this pull request
Jun 6, 2026
Issue: Generated text is not accurate (unable to identify object in given image) 5/25: Found a workaround, seems like compiler issue - debugging further --------- Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com>
vaibverm
pushed a commit
to vaibverm/efficient-transformers-blocking-techniques
that referenced
this pull request
Jun 6, 2026
Reverts quic#1010 Signed-off-by: Rishin Raj <rishinr@qti.qualcomm.com>
vaibverm
pushed a commit
to vaibverm/efficient-transformers-blocking-techniques
that referenced
this pull request
Jun 6, 2026
Issue: Generated text is not accurate (unable to identify object in given image) 5/25: Found a workaround, seems like compiler issue - debugging further --------- Signed-off-by: vtirumal <vtirumal@qti.qualcomm.com> Signed-off-by: Vaibhav Verma <vaibverm@qti.qualcomm.com>
vaibverm
pushed a commit
to vaibverm/efficient-transformers-blocking-techniques
that referenced
this pull request
Jun 6, 2026
Reverts quic#1010 Signed-off-by: Rishin Raj <rishinr@qti.qualcomm.com> Signed-off-by: Vaibhav Verma <vaibverm@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: Generated text is not accurate (unable to identify object in given image)
5/25: Found a workaround, seems like compiler issue - debugging further