Skip to content

Upgrading transformers version to latest 4.50 #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
quic-amitraj merged 23 commits into from
Apr 15, 2025
Merged

Upgrading transformers version to latest 4.50 #331

quic-amitraj merged 23 commits into from
Apr 15, 2025

Conversation

@quic-amitraj
Copy link
Contributor

@quic-amitraj quic-amitraj commented Mar 27, 2025 •
edited
Loading

  1. Upgrading transformers version to latest 4.50
  2. Code cleaned
  3. Fixed issue of DynamicCache

@quic-amitraj quic-amitraj added the wip Work in progress label Mar 27, 2025
@quic-amitraj quic-amitraj self-assigned this Mar 27, 2025
@quic-amitraj quic-amitraj force-pushed the tf_upgrade_4.50 branch 3 times, most recently from d194e98 to 492ef1f Compare April 1, 2025 05:06
@quic-amitraj quic-amitraj mentioned this pull request Apr 1, 2025
Closed
@quic-amitraj quic-amitraj requested a review from vbaddi April 2, 2025 08:42
@quic-amitraj quic-amitraj marked this pull request as ready for review April 2, 2025 08:43
@quic-amitraj quic-amitraj removed the wip Work in progress label Apr 2, 2025
@quic-amitraj quic-amitraj mentioned this pull request Apr 3, 2025
Merged
@quic-amitraj quic-amitraj force-pushed the tf_upgrade_4.50 branch 2 times, most recently from 7980900 to 6b06ea2 Compare April 8, 2025 04:40
vbaddi
vbaddi reviewed Apr 8, 2025
View reviewed changes
Copy link
Contributor

@vbaddi vbaddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks :)

@qcdipankar qcdipankar self-assigned this Apr 10, 2025
@quic-amitraj
Llama unabled for this model
3b2ee2b 
Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
@quic-amitraj
Enabled mpt for tf version -4.49.0
96abf89 
Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
@quic-amitraj
tf version 4.50 enanbled for llama, mpt and gemma
a3e91dc 
Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
@quic-amitraj
Enabled gemma2, codegen, falcon
74b3071 
Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
@quic-amitraj
Enabled gpt_bigcode, mistral, qwen, llava, internvl
235a72b 
Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
@quic-amitraj
Code cleaning and formating
37f2f7b 
Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
@quic-amitraj
llama clean
d0938a4 
Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
@quic-amitraj
falcon, gemma, gemma2, mistral, qwen clean up
5ee5591 
Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
quic-rishinr and others added 3 commits April 11, 2025 12:23
@quic-rishinr @quic-amitraj
Ruff format
eefc429 
Signed-off-by: Rishin Raj <quic_rishinr@quicinc.com>
Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
@quic-amitraj
Fixed quantizer issue
7ccd1d9 
Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
@quic-amitraj
Fixed issue of Lora
4744d65 
Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
@asmigosw @quic-amitraj
Removed unnecessary import (#355)
014f02c 
Removed unnecessary import

Signed-off-by: Asmita Goswami <quic_asmigosw@quicinc.com>
Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
@quic-amitraj
Minor fix
f51c54b 
Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
@ochougul
Copy link
Contributor

ochougul commented Apr 14, 2025

  • Remove unused imports from all modelling files.
  • Remove unused params from all forward methods or raise warnings
  • There are un-necessary if conditions for attention_mask and past_key_values
    But we know that we don't support attention_mask so it will always be None and we always need past_key_value so it will always be passed. so these if condition can be removed.

ochougul
ochougul requested changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@ochougul ochougul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of the comments apply to multiple files. please change the code in all files that follow same structure

ochougul
ochougul requested changes Apr 14, 2025
View reviewed changes
@quic-amitraj
Copy link
Contributor Author

quic-amitraj commented Apr 15, 2025

Key Note of this PR-

  1. Upgrade: Updated TensorFlow from version 4.46.3 to 4.50.0.
  2. Code Cleaning and Optimization: Performed code cleaning and optimizations across all modeling files to some extent. Further changes will be addressed in upcoming PRs to enhance the code quality.

@quic-amitraj
Comments Addressed
2f85e2a 
Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
@quic-amitraj
Comments addressed-2
b130e0e 
Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
@quic-amitraj
Copy link
Contributor Author

quic-amitraj commented Apr 15, 2025 •
edited
Loading

The further code cleaning of attention class and unused parameters will be done in upcoming PR.

@quic-amitraj
Minor fix-2
6044a3d 
Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
ochougul
ochougul approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@ochougul ochougul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving now. But few things need to be addressed.

  1. don't use if condition on attention_mask and past_key_value because we know their default values
  2. remove unused params from forward or raise warning
  3. change year to 2025 on top

@quic-amitraj
Copy link
Contributor Author

quic-amitraj commented Apr 15, 2025

Thanks @ochougul, all the suggested and pending changes will be addressed in upcoming PR.

@quic-amitraj quic-amitraj merged commit d7a2772 into main Apr 15, 2025
5 checks passed
@ochougul ochougul mentioned this pull request Apr 15, 2025
Merged
quic-dhirajku pushed a commit that referenced this pull request Apr 16, 2025
@quic-amitraj @qcdipankar
@asmigosw @quic-rishinr @quic-dhirajku
Upgrading transformers version to latest 4.50 (#331)
3dff579 
1. Upgrading transformers version to latest 4.50
2. Code cleaned
3. Fixed issue of `DynamicCache`

---------

Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
Signed-off-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Signed-off-by: Asmita Goswami <quic_asmigosw@quicinc.com>
Signed-off-by: Rishin Raj <quic_rishinr@quicinc.com>
Co-authored-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Co-authored-by: asmigosw <quic_asmigosw@quicinc.com>
Co-authored-by: Rishin Raj <quic_rishinr@quicinc.com>
quic-meetkuma pushed a commit to vbaddi/efficient-transformers that referenced this pull request Apr 21, 2025
@quic-amitraj @qcdipankar
@asmigosw @quic-rishinr @quic-meetkuma
Upgrading transformers version to latest 4.50 (quic#331)
4d6552d 
1. Upgrading transformers version to latest 4.50
2. Code cleaned
3. Fixed issue of `DynamicCache`

---------

Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
Signed-off-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Signed-off-by: Asmita Goswami <quic_asmigosw@quicinc.com>
Signed-off-by: Rishin Raj <quic_rishinr@quicinc.com>
Co-authored-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Co-authored-by: asmigosw <quic_asmigosw@quicinc.com>
Co-authored-by: Rishin Raj <quic_rishinr@quicinc.com>
eplatero97 pushed a commit to eplatero97/efficient-transformers that referenced this pull request Apr 29, 2025
@quic-amitraj @qcdipankar
@asmigosw @quic-rishinr @eplatero97
Upgrading transformers version to latest 4.50 (quic#331)
b577c8e 
1. Upgrading transformers version to latest 4.50
2. Code cleaned
3. Fixed issue of `DynamicCache`

---------

Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
Signed-off-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Signed-off-by: Asmita Goswami <quic_asmigosw@quicinc.com>
Signed-off-by: Rishin Raj <quic_rishinr@quicinc.com>
Co-authored-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Co-authored-by: asmigosw <quic_asmigosw@quicinc.com>
Co-authored-by: Rishin Raj <quic_rishinr@quicinc.com>
eplatero97 pushed a commit to eplatero97/efficient-transformers that referenced this pull request Apr 29, 2025
@quic-amitraj @qcdipankar
@asmigosw @quic-rishinr @eplatero97
Upgrading transformers version to latest 4.50 (quic#331)
f5a8f87 
1. Upgrading transformers version to latest 4.50
2. Code cleaned
3. Fixed issue of `DynamicCache`

---------

Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
Signed-off-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Signed-off-by: Asmita Goswami <quic_asmigosw@quicinc.com>
Signed-off-by: Rishin Raj <quic_rishinr@quicinc.com>
Co-authored-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Co-authored-by: asmigosw <quic_asmigosw@quicinc.com>
Co-authored-by: Rishin Raj <quic_rishinr@quicinc.com>
eplatero97 pushed a commit to eplatero97/efficient-transformers that referenced this pull request Apr 29, 2025
@quic-amitraj @qcdipankar
@asmigosw @quic-rishinr
Upgrading transformers version to latest 4.50 (quic#331)
71e7a0e 
1. Upgrading transformers version to latest 4.50
2. Code cleaned
3. Fixed issue of `DynamicCache`

---------

Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
Signed-off-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Signed-off-by: Asmita Goswami <quic_asmigosw@quicinc.com>
Signed-off-by: Rishin Raj <quic_rishinr@quicinc.com>
Co-authored-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Co-authored-by: asmigosw <quic_asmigosw@quicinc.com>
Co-authored-by: Rishin Raj <quic_rishinr@quicinc.com>
Signed-off-by: eplatero <quic_eplatero@quicinc.com>
eplatero97 pushed a commit to eplatero97/efficient-transformers that referenced this pull request Apr 29, 2025
@quic-amitraj @qcdipankar
@asmigosw @quic-rishinr @eplatero97
Upgrading transformers version to latest 4.50 (quic#331)
2fa80d7 
1. Upgrading transformers version to latest 4.50
2. Code cleaned
3. Fixed issue of `DynamicCache`

---------

Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
Signed-off-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Signed-off-by: Asmita Goswami <quic_asmigosw@quicinc.com>
Signed-off-by: Rishin Raj <quic_rishinr@quicinc.com>
Co-authored-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Co-authored-by: asmigosw <quic_asmigosw@quicinc.com>
Co-authored-by: Rishin Raj <quic_rishinr@quicinc.com>
Signed-off-by: eplatero <quic_eplatero@quicinc.com>
eplatero97 pushed a commit to eplatero97/efficient-transformers that referenced this pull request Apr 29, 2025
@quic-amitraj @eplatero97
Upgrading transformers version to latest 4.50 (quic#331)
c1ea635 
1. Upgrading transformers version to latest 4.50
2. Code cleaned
3. Fixed issue of `DynamicCache`

---------

Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
Signed-off-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Signed-off-by: Asmita Goswami <quic_asmigosw@quicinc.com>
Signed-off-by: Rishin Raj <quic_rishinr@quicinc.com>
Co-authored-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Co-authored-by: asmigosw <quic_asmigosw@quicinc.com>
Co-authored-by: Rishin Raj <quic_rishinr@quicinc.com>

Signed-off-by: eplatero <quic_eplatero@quicinc.com>
eplatero97 pushed a commit to eplatero97/efficient-transformers that referenced this pull request Apr 29, 2025
@quic-amitraj @qcdipankar
@asmigosw @quic-rishinr @eplatero97
Upgrading transformers version to latest 4.50 (quic#331)
ec164c0 
1. Upgrading transformers version to latest 4.50
2. Code cleaned
3. Fixed issue of `DynamicCache`

---------

Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
Signed-off-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Signed-off-by: Asmita Goswami <quic_asmigosw@quicinc.com>
Signed-off-by: Rishin Raj <quic_rishinr@quicinc.com>
Co-authored-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Co-authored-by: asmigosw <quic_asmigosw@quicinc.com>
Co-authored-by: Rishin Raj <quic_rishinr@quicinc.com>
Signed-off-by: eplatero <quic_eplatero@quicinc.com>
eplatero97 pushed a commit to eplatero97/efficient-transformers that referenced this pull request Apr 29, 2025
@quic-amitraj @eplatero97
Upgrading transformers version to latest 4.50 (quic#331)
26d652f 
1. Upgrading transformers version to latest 4.50
2. Code cleaned
3. Fixed issue of `DynamicCache`

---------

Signed-off-by: Amit Raj <quic_amitraj@quicinc.com>
Signed-off-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Signed-off-by: Asmita Goswami <quic_asmigosw@quicinc.com>
Signed-off-by: Rishin Raj <quic_rishinr@quicinc.com>
Co-authored-by: Dipankar Sarkar <quic_dipankar@quicinc.com>
Co-authored-by: asmigosw <quic_asmigosw@quicinc.com>
Co-authored-by: Rishin Raj <quic_rishinr@quicinc.com>

Signed-off-by: eplatero <quic_eplatero@quicinc.com>
@quic-rishinr quic-rishinr deleted the tf_upgrade_4.50 branch June 13, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vbaddi vbaddi vbaddi approved these changes

@ochougul ochougul ochougul approved these changes

@quic-rishinr quic-rishinr quic-rishinr approved these changes

Assignees

@quic-amitraj quic-amitraj

@qcdipankar qcdipankar

Labels

1.20.0 ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@quic-amitraj @ochougul @vbaddi @quic-rishinr @qcdipankar @asmigosw