Added Decoder layer class in Qeff for granite #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishek-singh591
requested review from
ochougul,
quic-amitraj,
quic-hemagnih and
quic-rishinr
as code owners
Signed-off-by: abhishek-singh591 <sabhis@qti.qualcomm.com>
abhishek-singh591
force-pushed
the
modeling_change_subfunction
branch
from
98210d4 to
059a0cf
Compare
vbaddi
approved these changes
Nov 20, 2025
abhishek-singh591
added a commit
to quic-rishinr/efficient-transformers
that referenced
this pull request
Nov 25, 2025
This PR introduces support for the Decoder layer class in Qeff for granite, which is required for the subfunction. While there are alternative approaches to achieve this, implementing it now ensures future compatibility, particularly if we decide to add CB support for Granite. In that case, the Qeff Granite Decoder layer will be necessary. Signed-off-by: abhishek-singh591 <sabhis@qti.qualcomm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for the Decoder layer class in Qeff for granite, which is required for the subfunction. While there are alternative approaches to achieve this, implementing it now ensures future compatibility, particularly if we decide to add CB support for Granite. In that case, the Qeff Granite Decoder layer will be necessary.