[QEff.Finetuning]CI enablement for Fine-Tuning #629
+324
−235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic-akuruvil
requested review from
ochougul,
quic-amitraj,
quic-hemagnih and
quic-rishinr
as code owners
quic-akuruvil
changed the title
quic-akuruvil
commented
Nov 24, 2025
tests/finetune/test_finetune.py
Outdated
| return results, all_ref_metrices, all_config_spy | ||
|
|
||
|
|
||
| @pytest.mark.skip() # remove when it's clear why diff val_step_loss values are observed in diff runs on existing code (even without PR #478 changes) |
Contributor
Author
There was a problem hiding this comment.
@tchawada Functional test, we should enable. Don't skip this.
quic-swatia
reviewed
Nov 24, 2025
Comment on lines
+9
to
+10
| LOSS_ATOL = 2e-2 | ||
| METRIC_ATOL = 3e-2 |
Contributor
There was a problem hiding this comment.
How are these values decided? Earlier we had tried to sync them with Eager team.
quic-swatia
reviewed
Nov 24, 2025
| clean_up(alpaca_json_path) | ||
|
|
||
|
|
||
| @pytest.mark.skip() # remove when it's clear why diff val_step_loss values are observed in diff runs on existing code (even without PR #478 changes) |
Contributor
There was a problem hiding this comment.
We are still skipping this?
Contributor
Author
There was a problem hiding this comment.
We want to keep only functional test on CI. This test case is for our local testing.
Contributor
There was a problem hiding this comment.
Please specify this in the description of the PR.
Signed-off-by: Ann Kuruvilla <akuruvil@qti.qualcomm.com>
Signed-off-by: Ann Kuruvilla <akuruvil@qti.qualcomm.com>
Signed-off-by: Tanisha <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha <tchawada@qti.qualcomm.com>
Signed-off-by: Ann Kuruvilla <akuruvil@qti.qualcomm.com>
Signed-off-by: Ann Kuruvilla <akuruvil@qti.qualcomm.com>
Signed-off-by: Ann Kuruvilla <akuruvil@qti.qualcomm.com>
Signed-off-by: Ann Kuruvilla <akuruvil@qti.qualcomm.com>
Signed-off-by: Ann Kuruvilla <akuruvil@qti.qualcomm.com>
Signed-off-by: Ann Kuruvilla <akuruvil@qti.qualcomm.com>
Signed-off-by: Ann Kuruvilla <akuruvil@qti.qualcomm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split testcase into functional and loss assertion, and enable on CI
Reference metrics data is updated to latest.