[QEff. Finetune] Adding callback and its test cases. #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
tchawada
requested review from
ochougul,
quic-amitraj,
quic-hemagnih and
quic-rishinr
as code owners
quic-meetkuma
requested changes
Dec 5, 2025
Contributor
quic-meetkuma
left a comment
quic-meetkuma
left a comment
There was a problem hiding this comment.
Looks good. Minor corrections. Post that let us merge it.
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
| except ValueError as e: | ||
| assert "Unknown callback" in str(e) | ||
| return | ||
| if hasattr(callback_inst, "callback"): |
Contributor
There was a problem hiding this comment.
Why we need to check the callback_inst.callback?
callback_inst itself is a callback and of type TrainerCallback. What am I missing?
Contributor
Author
There was a problem hiding this comment.
hasattr(callback_inst, "callback") checks whether the object is a wrapper that holds an inner callback or direct callback. So if it is wrapper need to check callback_inst.callback is not None.
quic-meetkuma
changed the title
Signed-off-by: Tanisha Chawada <tchawada@qti.qualcomm.com>
quic-meetkuma
approved these changes
Dec 8, 2025
Contributor
quic-meetkuma
left a comment
quic-meetkuma
left a comment
There was a problem hiding this comment.
Thanks for clean PR. Merging it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a Script for Registering and Retrieving Callback Classes
It has create_callback() function which creates an instance of callback.
Additionally, there is a test_callbacks.py script that validates the functionality and retrieval process.