Fixing the default value of CCL in infer.py#725
Merged
quic-rishinr merged 5 commits intoquic:mainfrom Jan 15, 2026
Merged
Conversation
Signed-off-by: Vahid Janfaza <vjanfaza@qti.qualcomm.com>
Signed-off-by: Vahid Janfaza <vjanfaza@qti.qualcomm.com>
Signed-off-by: Vahid Janfaza <vjanfaza@qti.qualcomm.com>
vjanfaza
requested review from
ochougul,
quic-amitraj,
quic-hemagnih and
quic-rishinr
as code owners
quic-rishinr
requested changes
Jan 14, 2026
| help="Define ccl list in csv format (e.g.,--comp-ctx-lengths 512,1024,2048).", | ||
| ) | ||
| parser.add_argument( | ||
| "--ccl_enabled", |
Contributor
There was a problem hiding this comment.
its better to keep the flag name as enable_ccl
Contributor
Author
There was a problem hiding this comment.
We have used this flag name in the ccl implementation. I think it's better to keep it consistent with other scripts.
quic-rishinr
requested changes
Jan 14, 2026
QEfficient/cloud/infer.py
Outdated
| if args.mxint8: | ||
| logger.warning("mxint8 is going to be deprecated in a future release, use -mxint8_kv_cache instead.") | ||
|
|
||
| ccl_enabled = kwargs.pop("ccl_enabled", False) |
Contributor
There was a problem hiding this comment.
instead of kwarg we can pass the CCL as a positional arg
Signed-off-by: Vahid Janfaza <vjanfaza@qti.qualcomm.com>
Contributor
|
Please update the description of the PR |
Contributor
Author
Added |
quic-rishinr
approved these changes
Jan 15, 2026
vjanfaza
added a commit
to vjanfaza/efficient-transformers
that referenced
this pull request
Jan 15, 2026
Since CCL is deactivated by default, the value of CCL lists (ccl_prefill and ccl_decode) should be None by default. In infer.py script the value of these lists wasn't None and it caused the problem of ccl activation by default. In this PR we addressed this issue. --------- Signed-off-by: Vahid Janfaza <vjanfaza@qti.qualcomm.com>
quic-rishinr
pushed a commit
that referenced
this pull request
Jan 19, 2026
Since CCL is deactivated by default, the value of CCL lists (ccl_prefill and ccl_decode) should be None by default. In infer.py script the value of these lists wasn't None and it caused the problem of ccl activation by default. In this PR we addressed this issue. --------- Signed-off-by: Vahid Janfaza <vjanfaza@qti.qualcomm.com>
tchawada
pushed a commit
to tchawada/QEff_tanisha
that referenced
this pull request
Feb 4, 2026
Since CCL is deactivated by default, the value of CCL lists (ccl_prefill and ccl_decode) should be None by default. In infer.py script the value of these lists wasn't None and it caused the problem of ccl activation by default. In this PR we addressed this issue. --------- Signed-off-by: Vahid Janfaza <vjanfaza@qti.qualcomm.com>
tchawada
pushed a commit
to tchawada/QEff_tanisha
that referenced
this pull request
Feb 4, 2026
Since CCL is deactivated by default, the value of CCL lists (ccl_prefill and ccl_decode) should be None by default. In infer.py script the value of these lists wasn't None and it caused the problem of ccl activation by default. In this PR we addressed this issue. --------- Signed-off-by: Vahid Janfaza <vjanfaza@qti.qualcomm.com>
tchawada
pushed a commit
to tchawada/QEff_tanisha
that referenced
this pull request
Feb 4, 2026
Since CCL is deactivated by default, the value of CCL lists (ccl_prefill and ccl_decode) should be None by default. In infer.py script the value of these lists wasn't None and it caused the problem of ccl activation by default. In this PR we addressed this issue. --------- Signed-off-by: Vahid Janfaza <vjanfaza@qti.qualcomm.com>
qcdipankar
pushed a commit
to qcdipankar/efficient-transformers
that referenced
this pull request
Feb 8, 2026
Since CCL is deactivated by default, the value of CCL lists (ccl_prefill and ccl_decode) should be None by default. In infer.py script the value of these lists wasn't None and it caused the problem of ccl activation by default. In this PR we addressed this issue. --------- Signed-off-by: Vahid Janfaza <vjanfaza@qti.qualcomm.com> Signed-off-by: Dipankar Sarkar <dipankar@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since CCL is deactivated by default, the value of CCL lists (ccl_prefill and ccl_decode) should be None by default. In infer.py script the value of these lists wasn't None and it caused the problem of ccl activation by default. In this PR we addressed this issue.